perf(db): cache db handles using OnceLock #6750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Feb 23, 2024
mattsse
added
C-debt
joshieDo
reviewed
Feb 24, 2024
| fn open_and_store_db<T: Table>(&self, slot: &OnceLock<DBI>) -> Result<DBI, DatabaseError> { | ||
| match self.inner.open_db(Some(T::NAME)) { | ||
| Ok(db) => { | ||
| slot.set(db.dbi()).unwrap(); |
There was a problem hiding this comment.
Already tried, this ends up as map(|db| db.dbi()).map_err(|| ..).inspect(|| slot.set().unwrap()), it's not any better
|
What's the perf improvement? |
OnceLock is cheaper to "lock" than a mutex. We can use this because we don't need mutable access after the first lazy initialization |
DaniPopes
force-pushed
the
dani/tx-handles-perf
branch
from
4c08107
to
9c9395f
Compare
DaniPopes
force-pushed
the
dani/tx-handles-perf
branch
from
9c9395f
to
f769c53
Compare
joshieDo
approved these changes
Feb 26, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need mutable access once to initialize the value.
Note that this doubles the size of the cache field on non-Linux (
OnceisAtomicU32on platforms withfutexsupport, otherwiseAtomicPtr)