Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace #[async_trait] with ->imp for traits in eth_wire #6756

Merged
merged 4 commits into from Feb 23, 2024
Merged

Replace #[async_trait] with ->imp for traits in eth_wire #6756

merged 4 commits into from Feb 23, 2024

Conversation

AbnerZheng
Copy link
Contributor

Refer to #6657
Replace #[async_trait] with ->imp for traits in eth_wire: CanDisconnect, NetworkInfo and Peer.

@mattsse mattsse added the C-debt A section of code is hard to understand or change label Feb 23, 2024
@mattsse mattsse added this pull request to the merge queue Feb 23, 2024
Merged via the queue into paradigmxyz:main with commit 34402ca Feb 23, 2024
30 checks passed
@AbnerZheng AbnerZheng deleted the replace-async-trait-in-eth-wire branch February 23, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt A section of code is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbnerZheng @mattsse