chore(deps): bump nybbles, correct some unchecked usages #6794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DaniPopes
commented
Feb 26, 2024
•
DaniPopes
commented
- bump dep
- moved benchmark to other repo alloy-rs/nybbles@723f170
- fixed nibble overflow in trie walker
DaniPopes
force-pushed
the
dani/bump-nybbles
branch
from
102aa04
to
d2fee58
Compare
mattsse
approved these changes
Feb 26, 2024
DaniPopes
force-pushed
the
dani/bump-nybbles
branch
from
86c08e0
to
5181850
Compare
rkrasiuk
approved these changes
Feb 26, 2024
crates/trie/src/walker.rs
Outdated
Comment on lines
187
to
193
| loop { | ||
| if subnode.state_flag() { | ||
| return Ok(()) | ||
| } | ||
| if subnode.nibble() == 0xf { | ||
| break; | ||
| } |
There was a problem hiding this comment.
this change should be fine because the current subnode gets discarded below anyway with self.stack.pop()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.