Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Remove op-node Rollup Config CLI Flag #6813

Merged
merged 3 commits into from Feb 27, 2024

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Feb 26, 2024

Description

The op-node has been updated to dynamically load the rollup config from the superchain registry. This pr updates the OP Stack Chain docs to specify a network instead of using a static json file. This avoids the need to have a rollup.json config file locally so instead you can just specify the network name.

Also note, specifying both the network and rollup.config is deprecated in the op-node. See https://github.com/ethereum-optimism/optimism/blob/develop/op-node/service.go#L216-L228

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mattsse mattsse added this pull request to the merge queue Feb 27, 2024
@mattsse mattsse added the A-op-reth Related to Optimism and op-reth label Feb 27, 2024
Merged via the queue into paradigmxyz:main with commit 0931fe1 Feb 27, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants