fix: actually use envelope encoding for pooled tx #6832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
C-bug
mattsse
force-pushed
the
matt/use-enveloped-encoding
branch
2 times, most recently
from
3a4491b
to
e7f440d
Compare
mattsse
force-pushed
the
matt/use-enveloped-encoding
branch
from
e7f440d
to
2d6e967
Compare
Rjected
approved these changes
Feb 27, 2024
| // The inner encoding is used with `with_header` set to true, making the final | ||
| // encoding: | ||
| // `tx_type || rlp([transaction_payload_body, blobs, commitments, proofs]))` | ||
| blob_tx.encode_with_type_inner(out, false); |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incredibly annoying.
can unify the function later but really don't want to deal with that rn.