Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): use mdbx_txn_reset to time out transactions #6850

Merged
merged 22 commits into from
Feb 29, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/storage/libmdbx-rs/src/transaction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,8 @@ impl TransactionPtr {
{
let _lck = self.lock.lock();

// When transaction is aborted via `TxnManager`, it's actually reset using `mdbn_txn_reset`
shekhirin marked this conversation as resolved.
Show resolved Hide resolved
// that makes the transaction unusable and sets the `MDBX_TXN_FINISHED` flag.
shekhirin marked this conversation as resolved.
Show resolved Hide resolved
if unsafe { ffi::mdbx_txn_flags(self.txn) } & ffi::MDBX_TXN_FINISHED != 0 {
return Err(Error::ReadTransactionAborted)
}
Expand Down
Loading