Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OP specific txpool #6902

Merged
merged 3 commits into from Mar 5, 2024
Merged

feat: add OP specific txpool #6902

merged 3 commits into from Mar 5, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 1, 2024

closes #5892

This adds a standalone tx validator for OP.

supersedes #6403

@mattsse mattsse requested a review from gakonst as a code owner March 1, 2024 08:46
@mattsse mattsse added the A-op-reth Related to Optimism and op-reth label Mar 1, 2024
@mattsse mattsse added the C-enhancement New feature or request label Mar 1, 2024
crates/node-optimism/src/node.rs Outdated Show resolved Hide resolved
@@ -145,14 +153,6 @@ where
origin: TransactionOrigin,
mut transaction: Tx,
) -> TransactionValidationOutcome<Tx> {
#[cfg(feature = "optimism")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, glad we can get rid of the cfgs

@mattsse mattsse added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit 405f9ab Mar 5, 2024
29 of 30 checks passed
@mattsse mattsse deleted the matt/add-op-specific-pool-type branch March 5, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add standalone optimism transaction validator
3 participants