Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not attempt clique header sender recovery on genesis #6916

Merged
merged 1 commit into from Mar 1, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Mar 1, 2024

Fixes #6910

EIP-225 mentions that the genesis header signature field in extradata is filled with zeros. This is because genesis clique extradata defines the initial authorized signers. This means we should not try to recover the signer for the genesis block.

@Rjected Rjected requested a review from gakonst as a code owner March 1, 2024 16:54
@Rjected Rjected added C-bug An unexpected or incorrect behavior A-consensus Related to the consensus engine labels Mar 1, 2024
@Rjected Rjected requested a review from mattsse March 1, 2024 17:02
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clique 👎

@Rjected Rjected added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit e7018ca Mar 1, 2024
29 checks passed
@Rjected Rjected deleted the dan/fix-goerli-header-signature branch March 1, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reth compiled from main panics on Goerli
2 participants