Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add engine API metrics graphs #6963

Merged
merged 1 commit into from Mar 5, 2024
Merged

feat: add engine API metrics graphs #6963

merged 1 commit into from Mar 5, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Mar 4, 2024

Added a graph for the existing metrics, fixes #5336

These could be split into separate graphs, one per endpoint version, wdyt @shekhirin

Graphs currently look like this
Screenshot 2024-03-04 at 3 22 49 PM

@Rjected Rjected added C-enhancement New feature or request A-observability Related to tracing, metrics, logs and other observability tools labels Mar 4, 2024
@Rjected Rjected requested a review from shekhirin March 4, 2024 20:25
@Rjected Rjected requested a review from gakonst as a code owner March 4, 2024 20:25
shekhirin
shekhirin approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that's very useful, IIUC:

  1. newPayload speed is important for general tip following and attestations
  2. forkchoiceUpdated speed is important for general tip following and block building

@Rjected Rjected added this pull request to the merge queue Mar 5, 2024
@shekhirin
Copy link
Collaborator

shekhirin commented Mar 5, 2024 •
edited

These could be split into separate graphs, one per endpoint version, wdyt

I think it's too many charts, our dashboard is already overloaded imo. So fine as it is now for me!

Merged via the queue into main with commit 04f24d4 Mar 5, 2024
29 checks passed
@Rjected Rjected deleted the dan/engine-metrics-histogram branch March 5, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Engine RPC API metrics graph
2 participants
@Rjected @shekhirin