Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bin): delete static files from highest to lowest in drop stage #6970

Merged
merged 1 commit into from Mar 5, 2024

Conversation

shekhirin
Copy link
Collaborator

Otherwise, update_index crashes because it can't find the static file for a lower block range

let mut segment_max_block = None;
if fixed_block_range.start() > 0 {
segment_max_block = Some(fixed_block_range.start() - 1)
};
self.update_index(segment, segment_max_block)?;

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-cli Related to the reth CLI A-static-files Related to static files labels Mar 5, 2024
@shekhirin shekhirin marked this pull request as ready for review March 5, 2024 12:58
@shekhirin shekhirin requested a review from onbjerg as a code owner March 5, 2024 12:58
@shekhirin shekhirin requested a review from joshieDo March 5, 2024 12:58
@shekhirin shekhirin added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit b24f9de Mar 5, 2024
29 checks passed
@shekhirin shekhirin deleted the alexey/stage-drop-order branch March 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-static-files Related to static files C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants