Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node tests crate #6972

Merged
merged 6 commits into from Mar 6, 2024
Merged

Node tests crate #6972

merged 6 commits into from Mar 6, 2024

Conversation

loocapro
Copy link
Contributor

@loocapro loocapro commented Mar 5, 2024

Closes #6626

@mattsse

Is the node-tests crate setup as you were imaging?

What other tests can I add?

mattsse
mattsse requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, this is great!

what I want to do is, move the tests to test folder, this way we can add more test support in the crate that we then can use for the e2e tests

crates/node-tests/src/main.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@loocapro loocapro marked this pull request as ready for review March 6, 2024 08:43
@loocapro loocapro requested a review from gakonst as a code owner March 6, 2024 08:43
@loocapro loocapro requested a review from mattsse March 6, 2024 08:43
mattsse
mattsse approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot!

ty

only one fmt issue remains

@mattsse mattsse added this pull request to the merge queue Mar 6, 2024
Merged via the queue into paradigmxyz:main with commit 9226488 Mar 6, 2024
30 checks passed
@mattsse mattsse mentioned this pull request Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write more node e2e tests
2 participants
@loocapro @mattsse