Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(staged-sync): correctly calculate total entries in bodies checkpoint #6992

Merged
merged 2 commits into from Mar 6, 2024
Merged

fix(staged-sync): correctly calculate total entries in bodies checkpoint #6992

merged 2 commits into from Mar 6, 2024

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Mar 6, 2024

Description

Closes #6975.

total checkpoint number needs to account for genesis block since processed number includes it.

@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior A-staged-sync Related to staged sync (pipelines and stages) labels Mar 6, 2024
shekhirin
shekhirin approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice find

@rkrasiuk rkrasiuk enabled auto-merge March 6, 2024 10:52
@rkrasiuk rkrasiuk added this pull request to the merge queue Mar 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2024
@rkrasiuk rkrasiuk added this pull request to the merge queue Mar 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2024
@shekhirin shekhirin added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 00f97f3 Mar 6, 2024
29 checks passed
@shekhirin shekhirin deleted the rkrasiuk/fix-bodies-checkpoint branch March 6, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-staged-sync Related to staged sync (pipelines and stages) C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subtraction with overflow node-core
3 participants
@rkrasiuk @shekhirin @mattsse