Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove redundant checking for if peer is banned #7069

Merged
merged 1 commit into from Mar 9, 2024
Merged

fix: remove redundant checking for if peer is banned #7069

merged 1 commit into from Mar 9, 2024

Conversation

int88
Copy link
Contributor

@int88 int88 commented Mar 9, 2024

best_unconnected() has filtered banned peers

@int88
fix: remove redundant checking for if peer is banned
ab11d90 
Signed-off-by: int88 <golden-miner@qq.com>
mattsse
mattsse approved these changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is indeed redundant ty

@mattsse mattsse added this pull request to the merge queue Mar 9, 2024
@mattsse mattsse added C-debt A section of code is hard to understand or change A-networking Related to networking in general labels Mar 9, 2024
Merged via the queue into paradigmxyz:main with commit 6dbc5e0 Mar 9, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-debt A section of code is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@int88 @mattsse