fix: ban trusted peer for a short period #7071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
previously requested changes
Mar 10, 2024
| if peer.is_trusted() { | ||
| self.ban_list.ban_peer_until( | ||
| peer_id, | ||
| std::time::Instant::now() + self.backoff_durations.medium, |
There was a problem hiding this comment.
please import Instant in prelude of module
There was a problem hiding this comment.
Already prelude Instant of tokio, conflict?
| if peer.is_trusted() { | ||
| self.ban_list.ban_peer_until( | ||
| peer_id, | ||
| std::time::Instant::now() + self.backoff_durations.medium, |
There was a problem hiding this comment.
where did self.backoff_durations.medium come from? isn't it supposed to use a fraction of self.ban_duration?
There was a problem hiding this comment.
As discussed with @mattsse
There was a problem hiding this comment.
Then will let @mattsse continue review :)
mattsse
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7056