Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reth/db: make code more readable #7094

Merged
merged 3 commits into from Mar 11, 2024
Merged

reth/db: make code more readable #7094

merged 3 commits into from Mar 11, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Mar 11, 2024

make the code more readable:

  1. use variable db_log_level to avoid duplicated;
  2. make freelist_size calculate more understandable;
  3. return error of the segment info

@jsvisa
reth/db: use var db_log_level intead of repeated DatabaseArguments
d45dc52 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
db/stats: error of segment
f5f68c2 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
db/stats: more readable freelist calculator
e6715ac 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa jsvisa requested a review from onbjerg as a code owner March 11, 2024 10:19
@DaniPopes DaniPopes added this pull request to the merge queue Mar 11, 2024
Merged via the queue into paradigmxyz:main with commit 5ce8034 Mar 11, 2024
27 checks passed
@jsvisa jsvisa deleted the reth-db-dry branch March 11, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsvisa @onbjerg @DaniPopes