Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: headers first stage #7127

Merged
merged 1 commit into from Mar 13, 2024
Merged

test: headers first stage #7127

merged 1 commit into from Mar 13, 2024

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Mar 13, 2024 •
edited

Description

Adds a test for the first stage, see comment for more info. Would have caught #7116

@rkrasiuk rkrasiuk added A-staged-sync Related to staged sync (pipelines and stages) C-test A change that impacts how or what we test labels Mar 13, 2024
@rkrasiuk rkrasiuk requested a review from gakonst as a code owner March 13, 2024 07:47
shekhirin
shekhirin approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@rkrasiuk rkrasiuk added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit b05f8a9 Mar 13, 2024
27 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/test-headers-first-stage branch March 13, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@rswanson rswanson Awaiting requested review from rswanson

@Rjected Rjected Awaiting requested review from Rjected

@onbjerg onbjerg Awaiting requested review from onbjerg

@rakita rakita Awaiting requested review from rakita

@mattsse mattsse Awaiting requested review from mattsse

@DaniPopes DaniPopes Awaiting requested review from DaniPopes

@emhane emhane Awaiting requested review from emhane

@joshieDo joshieDo Awaiting requested review from joshieDo

Assignees
No one assigned
Labels
A-staged-sync Related to staged sync (pipelines and stages) C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rkrasiuk @shekhirin