Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply block overrides before create env #7135

Merged
merged 1 commit into from Mar 13, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 13, 2024

Closes #6240

Apply block overrides before creating the call env so base fee overrides take effect when validating fees

still tbd if we should remove the max_fee < block.basefee check for calls, need to check other impls

@mattsse mattsse requested a review from Rjected as a code owner March 13, 2024 19:17
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Mar 13, 2024
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, it would be nice to have tests for these environment methods

@mattsse mattsse added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 455b2af Mar 13, 2024
27 checks passed
@mattsse mattsse deleted the matt/apply-block-overrides-before branch March 13, 2024 21:08
@geomad
Copy link

geomad commented Mar 15, 2024

Closes #6240

Apply block overrides before creating the call env so base fee overrides take effect when validating fees

still tbd if we should remove the max_fee < block.basefee check for calls, need to check other impls

Allowing 0 fee calls is useful, for example simulating the diff of eth in a wallet after a swap. Not allowing 0 Base fee would require extra calls and math to subtract the gas used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockOverride:baseFee is not working for CallMany and TraceCall
3 participants