Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node-core, stages): stage preparation notification #7156

Merged
merged 3 commits into from Mar 15, 2024
Merged

feat(node-core, stages): stage preparation notification #7156

merged 3 commits into from Mar 15, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Mar 15, 2024 •
edited 

2024-03-15T13:46:17.280996Z  INFO Preparing stage pipeline_stages=1/12 stage=Headers checkpoint=1145708 target=1145713
2024-03-15T13:46:17.348535Z  INFO Received headers total=5 from_block=1145713 to_block=1145709
2024-03-15T13:46:17.348778Z  INFO Executing stage pipeline_stages=1/12 stage=Headers checkpoint=1145708 target=1145713
2024-03-15T13:46:17.348790Z  INFO Writing headers total=5
2024-03-15T13:46:17.371114Z  INFO Writing header hash index total=5
2024-03-15T13:46:17.375032Z  INFO Stage finished executing pipeline_stages=1/12 stage=Headers checkpoint=1145713 target=1145713 stage_progress=100.00%

TODO (will create an issue): make it not emit the notification for those stages that don't require the poll_execute_ready call.

@shekhirin shekhirin added C-enhancement New feature or request A-staged-sync Related to staged sync (pipelines and stages) A-observability Related to tracing, metrics, logs and other observability tools labels Mar 15, 2024
@shekhirin shekhirin marked this pull request as ready for review March 15, 2024 15:37
@shekhirin shekhirin requested a review from joshieDo March 15, 2024 15:37
@shekhirin shekhirin mentioned this pull request Mar 15, 2024
Merged
mattsse
mattsse approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@shekhirin shekhirin added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 4c3ab9a Mar 15, 2024
27 checks passed
@shekhirin shekhirin deleted the alexey/stage-prepare-notification branch March 15, 2024 20:15
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
@shekhirin @Ruteri
feat(node-core, stages): stage preparation notification (paradigmxyz#…
83fdd8a 
…7156)
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
@shekhirin @Ruteri
feat(node-core, stages): stage preparation notification (paradigmxyz#…
53f14db 
…7156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo joshieDo approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-staged-sync Related to staged sync (pipelines and stages) C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shekhirin @mattsse @joshieDo