fix: decrease connection info based on current state #7165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug where we were calling
self.connection_info.decr_out();
when we should have updated the connection info based on the current state of the peer.This is not possible to Hit under normal operations only if manually triggered via
reth/crates/net/network/src/session/handle.rs
Lines 27 to 28 in 71f8581
which we currently don't do.
also renames the function properly