Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grafana): fetch each query with instance as filter #7173

Merged
merged 1 commit into from Mar 17, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Mar 16, 2024

I'm running multiple instances, and all the instances' metrics are stored in one Prometheus, some dashboard results are not filtered with the instance, we should always filter with the instance for the extracted result.

Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa jsvisa requested a review from gakonst as a code owner March 16, 2024 00:30
@jsvisa
Copy link
Contributor Author

jsvisa commented Mar 16, 2024

@emhane PTAL

Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

etc/grafana/dashboards/overview.json Show resolved Hide resolved
@emhane emhane added this pull request to the merge queue Mar 17, 2024
Merged via the queue into paradigmxyz:main with commit 3a10c31 Mar 17, 2024
27 checks passed
@jsvisa jsvisa deleted the grafana-expr-instance branch March 17, 2024 23:57
@emhane
Copy link
Member

emhane commented Mar 18, 2024

applied these changes to public dashboard now, thanks again, very helpful @jsvisa https://reth.paradigm.xyz/d/2k8BXz24x/reth?orgId=1&refresh=30s

Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants