Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Config into admin_nodeInfo response #7206

Merged
merged 4 commits into from Mar 20, 2024
Merged

Integrate Config into admin_nodeInfo response #7206

merged 4 commits into from Mar 20, 2024

Conversation

tcoratger
Copy link
Contributor

Should close #7205.

@tcoratger tcoratger requested a review from emhane as a code owner March 19, 2024 08:43
mattsse
mattsse requested changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, only 1 small nit

crates/rpc/rpc/src/admin.rs Outdated Show resolved Hide resolved
crates/net/network-api/src/noop.rs Show resolved Hide resolved
@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Mar 19, 2024
onbjerg
onbjerg approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mattsse
mattsse approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@mattsse mattsse added this pull request to the merge queue Mar 20, 2024
Merged via the queue into paradigmxyz:main with commit 0a803c4 Mar 20, 2024
28 checks passed
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
@tcoratger @Ruteri
Integrate Config into admin_nodeInfo response (paradigmxyz#7206)
892aabb
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
@tcoratger @Ruteri
Integrate Config into admin_nodeInfo response (paradigmxyz#7206)
541d505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@Evalir Evalir Awaiting requested review from Evalir

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Config into admin_nodeInfo response
3 participants
@tcoratger @onbjerg @mattsse