Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display the reth version in the log #7207

Merged
merged 1 commit into from Mar 19, 2024

Conversation

winksaville
Copy link
Contributor

This allows the user to determine what version is running when inspecting the logs.

This allows the user to determine what version is running when inspecting
the logs.
@shekhirin shekhirin added A-cli Related to the reth CLI C-enhancement New feature or request A-observability Related to tracing, metrics, logs and other observability tools labels Mar 19, 2024
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shekhirin shekhirin added this pull request to the merge queue Mar 19, 2024
Merged via the queue into paradigmxyz:main with commit 28157f0 Mar 19, 2024
27 checks passed
@winksaville winksaville deleted the Log-reth-version branch March 19, 2024 16:43
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants