Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BeaconConsensusEvent for live sync download requests #7230

Merged
merged 3 commits into from Mar 19, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Mar 19, 2024

Creates a new BeaconConsensusEngineEvent variant called LiveSyncProgress. This is used by the sync controller to notify consumers about live sync progress. Currently there is only one variant in LiveSyncProgress, but this could be expanded to convey information about execution for example.

When listeners are pushed to the engine, they are now also cloned pushed to the sync controller.

The logs look like this:

2024-03-19T16:11:10.682764Z  INFO reth_node_core::events::node: Live sync in progress, downloading blocks remaining_blocks=62 target_block_hash=0xfa057bb40cfce0f280aee652e5baddb2c4c2d10926316fe1edbc8f54e3fbb17f

Ref #7134

@Rjected Rjected added C-enhancement New feature or request A-observability Related to tracing, metrics, logs and other observability tools A-downloaders Related to headers/bodies downloaders labels Mar 19, 2024
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

crates/consensus/beacon/src/engine/event.rs Outdated Show resolved Hide resolved
crates/consensus/beacon/src/engine/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
@Rjected Rjected enabled auto-merge March 19, 2024 17:04
@Rjected Rjected added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit ce89a2b Mar 19, 2024
27 checks passed
@Rjected Rjected deleted the dan/improved-live-sync-logs branch March 19, 2024 17:21
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-downloaders Related to headers/bodies downloaders A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants