New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement ots_getTransactionError endpoints #7316
Conversation
crates/rpc/rpc/src/otterscan.rs
Outdated
@@ -45,7 +47,22 @@ where | |||
|
|||
/// Handler for `ots_getTransactionError` | |||
async fn get_transaction_error(&self, _tx_hash: TxHash) -> RpcResult<String> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to make two changes here:
- change this to
Option<Bytes>
- only return Some if Revert
ref:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
I only changed the return value to an Option
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
close #7309