Implement ots_getInternalOperations
#7332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbnerZheng
requested review from
mattsse,
Rjected,
Evalir,
emhane and
gakonst
as code owners
mattsse
requested changes
Mar 25, 2024
crates/rpc/rpc-types/Cargo.toml
Outdated
| @@ -21,6 +21,7 @@ alloy-rpc-engine-types = { workspace = true, features = ["jsonrpsee-types"] } | |||
| ethereum_ssz_derive = { version = "0.5", optional = true } | |||
| ethereum_ssz = { version = "0.5", optional = true } | |||
| alloy-genesis.workspace = true | |||
| revm-inspectors.workspace = true | |||
There was a problem hiding this comment.
I don't want the dep here we can convert this in the request impl, because we only really need it there
and eventually we will move the otterscan types to alloy and then can do the conversion natively in revm-inspectors
crates/rpc/rpc/src/otterscan.rs
Outdated
| ) | ||
| .await? | ||
| .map(|transfer_operations| transfer_operations.into_iter().map(Into::into).collect()) | ||
| .ok_or_else(|| internal_rpc_err("failed to inspect transaction")) |
There was a problem hiding this comment.
this is not required, can use ? here I believe
There was a problem hiding this comment.
I can't use ? on Option<Vec<InternalOperation> to get Result<Vec<InternalOperation>, Err>, so I use unwrap_or_default to the inside content and return with Ok
crates/rpc/rpc/src/otterscan.rs
Outdated
| |_tx_info, inspector, _, _| Ok(inspector.into_transfers()), | ||
| ) | ||
| .await? | ||
| .map(|transfer_operations| transfer_operations.into_iter().map(Into::into).collect()) |
There was a problem hiding this comment.
let's move the conversion in here
mattsse
added
C-enhancement
mattsse
approved these changes
Mar 26, 2024
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #7310