Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent duplicate events for single blocks #7335

Merged
merged 1 commit into from Mar 26, 2024
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 25, 2024

download_full_block already emits this event, this prevents logging it twice

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Mar 25, 2024
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right, nice catch, lgtm

@mattsse mattsse added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit e97c973 Mar 26, 2024
27 checks passed
@mattsse mattsse deleted the matt/move-engine-event branch March 26, 2024 11:53
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants