feat: --db.exclusive flag for nfs volumes
#7346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the purpose of this is to further extend paradigmxyz#6755 and allow for `--db.exclusive=true` to be used to support nfs volumes
onbjerg
added
C-enhancement
onbjerg
changed the title
--db.exclusive flag for nfs volumes
onbjerg
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Please also update the command help in the book: https://github.com/paradigmxyz/reth/tree/main/book/cli/reth
* update book help text * linting
shekhirin
reviewed
Mar 27, 2024
| @@ -12,13 +12,17 @@ pub struct DatabaseArgs { | |||
| /// Database logging level. Levels higher than "notice" require a debug build. | |||
| #[arg(long = "db.log-level", value_enum)] | |||
| pub log_level: Option<LogLevel>, | |||
| /// Open environment in exclusive/monopolistic mode. Enabling allows nfs volumes | |||
There was a problem hiding this comment.
Suggested change
| /// Open environment in exclusive/monopolistic mode. Enabling allows nfs volumes | |
| /// Open environment in exclusive/monopolistic mode. Makes it possible to open a database on an NFS volume. |
book/cli/reth/node.md
Outdated
Comment on lines
437
to
441
| --db.exclusive <EXCLUSIVE> | ||
| Exclusion mode enabled or not | ||
|
|
||
| [possible values: true, false] | ||
|
|
There was a problem hiding this comment.
This can be generated with make update-book-cli, the description of the argument should match the rustdoc comment.
* fix verbiage for rustdoc * run update-book-cli *note this caught more than just my changes*
shekhirin
approved these changes
Mar 28, 2024
| @@ -12,13 +12,18 @@ pub struct DatabaseArgs { | |||
| /// Database logging level. Levels higher than "notice" require a debug build. | |||
| #[arg(long = "db.log-level", value_enum)] | |||
| pub log_level: Option<LogLevel>, | |||
| /// Open environment in exclusive/monopolistic mode. Makes it possible to open a database on an | |||
| /// NFS volume. | |||
| #[arg(long = "db.exclusive", exclusive = false)] | |||
There was a problem hiding this comment.
do we need exclusive here? https://docs.rs/clap/latest/clap/struct.Arg.html#method.exclusive
it doesn't set the default value for the argument, think we should rather leave it as None when not specified
There was a problem hiding this comment.
Ah OK that makes sense. Thanks for the link to the docs as well. Change incoming
remove exclusive flag based on misunderstanding of call, default works like exclusive=false anyways so comes across as redundant
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to further extend #6755 and allow for
--db.exclusive=trueto be used to support nfs volumes