Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce merkle clean_threshold to 5000 #7364

Merged
merged 1 commit into from Apr 2, 2024
Merged

fix: reduce merkle clean_threshold to 5000 #7364

merged 1 commit into from Apr 2, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Mar 27, 2024 •
edited

This changes the merkle clean_threshold to 5000, because 50_000 was causing OOMs during the merkle stage. This is because the incremental calculation (only run if range < clean_threshold) at 50_000 was collecting over 10GB of TrieUpdates.

Jemalloc memory metrics for the stage:
Screenshot 2024-04-01 at 1 57 04 PM

Stage progress during the same timeframe:
Screenshot 2024-04-01 at 1 57 29 PM

@Rjected Rjected added C-bug An unexpected or incorrect behavior A-staged-sync Related to staged sync (pipelines and stages) C-perf A change motivated by improving speed, memory usage or disk footprint A-trie Related to Merkle Patricia Trie implementation labels Mar 27, 2024
@Rjected Rjected marked this pull request as ready for review March 29, 2024 17:42
emhane
emhane approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mattsse
mattsse approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

one thing to note, this does not apply to nodes that are restarted with an existing reth.toml

@Rjected Rjected added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit f63cebb Apr 2, 2024
27 checks passed
@Rjected Rjected deleted the dan/lower-merkle-threshold branch April 2, 2024 17:47
This was referenced Apr 9, 2024
Closed
Closed
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
@Rjected @Ruteri
fix: reduce merkle clean_threshold to 5000 (paradigmxyz#7364)
41b61e2
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
@Rjected @Ruteri
fix: reduce merkle clean_threshold to 5000 (paradigmxyz#7364)
66e64ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane emhane approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-staged-sync Related to staged sync (pipelines and stages) A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rjected @mattsse @emhane