feat: Implement BlockReader::block_with_senders_range #7402
Conversation
AbnerZheng
requested review from
mattsse,
Rjected,
rakita,
joshieDo and
shekhirin
as code owners
crates/rpc/rpc/src/trace.rs
Outdated
There was a problem hiding this comment.
please keep this pr limited to adding the new function
| let len = range.end().saturating_sub(*range.start()) as usize; | ||
| let mut blocks = Vec::with_capacity(len); | ||
|
|
||
| let mut headers_cursor = self.tx.cursor_read::<tables::Headers>()?; |
There was a problem hiding this comment.
| let senders = senders_cursor | ||
| .walk_range(tx_range)? | ||
| .map(|entry| entry.map(|(_, sender)| sender)) | ||
| .collect::<Result<Vec<_>, _>>()?; |
There was a problem hiding this comment.
senders might be missing from the table if they are pruned, there other provider functions that can be used to get them, so you might need to do a mix of fetching what you can, and recover the rest (take a look at senders_by_tx_range)
There was a problem hiding this comment.
otherwise, if they are pruned try_with_senders_unchecked will be recalculating every sender from the body, since txes.len != senders.len
If the above comment suggestion seems too complex, you could just let try_with_senders_unchecked calculate the senders by passing an empty vec. It can be improved on another PR
There was a problem hiding this comment.
Never mind, will give it a try later.
|
ping @joshieDo |
| for (tx_num, tx) in tx_range.zip(body.iter()) { | ||
| match known_senders.get(&tx_num) { | ||
| None => { | ||
| // recover the sender from the transaction if not found | ||
| let sender = tx | ||
| .recover_signer_unchecked() | ||
| .ok_or_else(|| ProviderError::SenderRecoveryError)?; | ||
| senders.push(sender); | ||
| } | ||
| Some(sender) => senders.push(*sender), |
There was a problem hiding this comment.
There might be an improved performance route here by collecting all txes ref in a list and recover all signers in parallel, but can be done in a follow-up imo
| .map(|(_, o)| o.ommers) | ||
| .unwrap_or_default() | ||
| }; | ||
| if let Ok(b) = process_tx(tx_range, header, ommers, withdrawals) { |
There was a problem hiding this comment.
process_tx is a weird name here tho
|
@mattsse PTAL |
close #7395