Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use modify specid instead #7427

Merged
merged 1 commit into from Apr 2, 2024
Merged

fix: use modify specid instead #7427

merged 1 commit into from Apr 2, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Apr 2, 2024

this ensures we're not deleting any registered handlers.

This is okay because OP modifications are also pushed as handler register
and this is part of the EvmConfig init

@mattsse mattsse added the A-execution Related to the Execution and EVM label Apr 2, 2024
@mattsse mattsse requested a review from rakita April 2, 2024 15:26
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattsse mattsse added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 16c76b6 Apr 2, 2024
27 checks passed
@mattsse mattsse deleted the matt/use-modify-spec-id branch April 2, 2024 17:53
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants