feat(examples): minimal viable ExEx #7565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
shekhirin
force-pushed
the
alexey/minimal-exex
branch
from
0aed582
to
d2962cc
Compare
mattsse
approved these changes
Apr 11, 2024
examples/exex/minimal/src/main.rs
Outdated
| let this = self.get_mut(); | ||
|
|
||
| // Process all new chain state notifications until there are no more | ||
| while let Poll::Ready(Some(notification)) = this.ctx.notifications.poll_recv(cx) { |
There was a problem hiding this comment.
while let Some(notification) = ready!(
and return Ok(()) on end
mattsse
approved these changes
Apr 11, 2024
onbjerg
approved these changes
Apr 11, 2024
Comment on lines
+33
to
+34
| old.first().number..=old.tip().number, | ||
| new.first().number..=new.tip().number |
There was a problem hiding this comment.
nit: include hashes of the old/new tip otherwise it might look confusing if we reorg a similar chain length
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7557