Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move tree setup to builder #7577

Merged
merged 1 commit into from Apr 11, 2024
Merged

chore: move tree setup to builder #7577

merged 1 commit into from Apr 11, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Apr 11, 2024

all the nodeconfig setup code is more or less debt and belongs in the builder crate instead

this first moves tree setup to builder.

@mattsse mattsse requested a review from onbjerg April 11, 2024 20:30
@mattsse mattsse added the C-debt A section of code is hard to understand or change label Apr 11, 2024
@mattsse mattsse requested a review from shekhirin April 11, 2024 20:34
@mattsse mattsse added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit 6a83391 Apr 11, 2024
28 checks passed
@mattsse mattsse deleted the matt/move-tree-setup-to-builder branch April 11, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin

Assignees
No one assigned
Labels
C-debt A section of code is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattsse @onbjerg