Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node-api): move FullNodeComponents from builder #7597

Merged
merged 7 commits into from Apr 12, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Apr 12, 2024

Unblocks #7573 (review)

@shekhirin shekhirin added C-debt A section of code is hard to understand or change A-sdk Related to reth's use as a library labels Apr 12, 2024
@shekhirin shekhirin changed the title chore(node-api): move FullNodeComponents from builder chore(node-api): move FullNodeComponents from builder Apr 12, 2024
@shekhirin shekhirin requested a review from mattsse April 12, 2024 14:13
@shekhirin shekhirin force-pushed the alexey/node-api-full-node-components branch from 2ca84c4 to 6486c42 Compare April 12, 2024 14:17
Base automatically changed from matt/remove-node-api-deps to main April 12, 2024 14:21
@shekhirin shekhirin marked this pull request as ready for review April 12, 2024 14:33
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shekhirin shekhirin added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit e1ebc2f Apr 12, 2024
28 checks passed
@shekhirin shekhirin deleted the alexey/node-api-full-node-components branch April 12, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-debt A section of code is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants