feat: add rpc trait bindings for optimism specific endpoints #7621

AbnerZheng · 2024-04-13T15:06:10Z

close #7540

Check whether it is in the right direction.

mattsse

nice, this is the right direction.

I'm okay with the location for now, but we will move this shortly

crates/rpc/rpc-api/src/optimism.rs

mattsse · 2024-04-14T12:45:01Z

crates/rpc/rpc-api/src/optimism.rs

+    pub hash: BlockHash,
+    pub number: BlockNumber,
+    pub parent_hash: BlockHash,
+    pub timestamp: U64,


use u64 and serde with alloy::u64_hex

crates/rpc/rpc-api/src/optimism.rs

crates/rpc/rpc-api/Cargo.toml

mattsse · 2024-04-15T11:47:09Z

crates/rpc/rpc-api/src/optimism.rs

+    pub hash: B256,
+    pub number: BlockNumber,
+    pub parent_hash: B256,
+    pub timestamp: U64,


should also use primitive u64 with alloy_serde::u64_hex

Having turn it to u64, but alloy_serde::u64_hex should not be needed.

https://github.com/AbnerZheng/reth/blob/846977e911e834452827bace98ad31bb5903d98b/crates/rpc/rpc-api/src/optimism.rs#L332-L337

AbnerZheng · 2024-04-15T11:52:36Z

Turn it to a draft PR, since there are still much more APIs and tests to add. Sorry for bothering, and will ping you if ready.

mattsse · 2024-04-15T12:05:18Z

Sorry for bothering, and will ping you if ready.

no worries, ping anytime :)

AbnerZheng · 2024-04-15T16:01:24Z

@mattsse It's ready for review now. PTAL when available.

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

mattsse

nice,

lats nits,

please double check u64 usage which should use alloy_rpc_types::serde::u64_hex if hex

mattsse · 2024-04-15T21:39:36Z

crates/rpc/rpc-api/src/test.json

please inline this, I want to move the types sone and have a string with this would be easier

Good suggestion. Done.

mattsse · 2024-04-15T21:40:01Z

crates/rpc/rpc-api/src/optimism.rs

    pub chain_id: ChainId,
-    pub latency: Duration,
+    pub latency: u64,


is this seconds or ms?

time.duration in go, it should be nanosecond.

mattsse · 2024-04-15T21:41:20Z

crates/rpc/rpc-api/src/optimism.rs

+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub l1_chain_id: Option<u128>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub l2_chain_id: Option<u128>,

+    #[serde(skip_serializing_if = "Option::is_none")]
    pub regolith_time: Option<u64>,
+    #[serde(skip_serializing_if = "Option::is_none")]
    pub canyon_time: Option<u64>,
+    #[serde(skip_serializing_if = "Option::is_none")]
    pub delta_time: Option<u64>,
+    #[serde(skip_serializing_if = "Option::is_none")]
    pub ecotone_time: Option<u64>,
+    #[serde(skip_serializing_if = "Option::is_none")]
    pub fjord_time: Option<u64>,
+    #[serde(skip_serializing_if = "Option::is_none")]
    pub interop_time: Option<u64>,
    pub batch_inbox_address: Address,
    pub deposit_contract_address: Address,
    pub l1_system_config_address: Address,
+    #[serde(skip_serializing_if = "Option::is_none")]
    pub protocol_versions_address: Option<Address>,
+    #[serde(skip_serializing_if = "Option::is_none")]
    pub da_challenge_address: Option<Address>,


all skips, need default attribute

mattsse · 2024-04-15T21:42:24Z

crates/rpc/rpc-api/src/optimism.rs

+    pub batcher_addr: Address,
+    pub overhead: B256,
+    pub scalar: B256,
+    pub gas_limit: u64,


this must serialize with hex alloy_rpc_types::serde::u64_hex

I have updated tests and
utilize the result returned from a truly running node in tests, as provided
by QuickNode. You can use

curl https://docs-demo.optimism.quiknode.pro/ \ -X POST \ -H "Content-Type: application/json" \ --data '{"method":"optimism_syncStatus","params":[],"id":1,"jsonrpc":"2.0"}'

and

curl https://docs-demo.optimism.quiknode.pro/ \ -X POST \ -H "Content-Type: application/json" \ --data '{"method":"optimism_rollupConfig","params":[],"id":1,"jsonrpc":"2.0"}'

to get rpc result, in these response, the "timestamp" is 1713235375, gasLimit is 30000000, both of them are not hex encoded.

For more information, refer to the QuickNode documentation
at https://www.quicknode.com/docs/optimism/optimism_rollupConfig.

mattsse · 2024-04-15T21:42:36Z

crates/rpc/rpc-api/src/optimism.rs

@@ -27,7 +33,7 @@ pub struct L1BlockRef {
    pub hash: B256,
    pub number: BlockNumber,
    pub parent_hash: B256,
-    pub timestamp: U64,
+    pub timestamp: u64,


I believe this also needs
alloy_rpc_types::serde::u64_hex

Utilize the result returned from a trully running node, as provided by QuickNode. For more information, refer to the QuickNode documentation at https://www.quicknode.com/docs/optimism/optimism_rollupConfig.

mattsse

ty!

wip

dbee0a5

mattsse requested changes Apr 14, 2024

View reviewed changes

mattsse added the A-rpc Related to the RPC implementation label Apr 14, 2024

mattsse marked this pull request as ready for review April 14, 2024 12:46

mattsse requested review from Rjected, onbjerg, rkrasiuk and gakonst as code owners April 14, 2024 12:46

apply suggestion from code review

b718ecd

mattsse requested changes Apr 15, 2024

View reviewed changes

AbnerZheng marked this pull request as draft April 15, 2024 11:51

AbnerZheng added 2 commits April 15, 2024 23:49

add remaining api methods

dfaa50f

fix test

2733897

AbnerZheng marked this pull request as ready for review April 15, 2024 15:57

fix lint

846977e

AbnerZheng and others added 2 commits April 16, 2024 00:02

Update crates/rpc/rpc-api/Cargo.toml

7387dc7

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

remove temporary test file

806ba50

mattsse requested changes Apr 15, 2024

View reviewed changes

AbnerZheng added 3 commits April 16, 2024 10:57

apply suggestion from code review and update tests

e8c296d

Utilize the result returned from a trully running node, as provided by QuickNode. For more information, refer to the QuickNode documentation at https://www.quicknode.com/docs/optimism/optimism_rollupConfig.

add comment for latency

e8086aa

inline json in tests

2ff1d4c

mattsse approved these changes Apr 16, 2024

View reviewed changes

mattsse added this pull request to the merge queue Apr 16, 2024

Merged via the queue into paradigmxyz:main with commit 516e836 Apr 16, 2024
28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add rpc trait bindings for optimism specific endpoints #7621

feat: add rpc trait bindings for optimism specific endpoints #7621

AbnerZheng commented Apr 13, 2024

mattsse left a comment

mattsse Apr 14, 2024

mattsse Apr 15, 2024

AbnerZheng Apr 15, 2024

AbnerZheng commented Apr 15, 2024

mattsse commented Apr 15, 2024

AbnerZheng commented Apr 15, 2024

mattsse left a comment

mattsse Apr 15, 2024

AbnerZheng Apr 16, 2024

mattsse Apr 15, 2024

AbnerZheng Apr 16, 2024

mattsse Apr 15, 2024

AbnerZheng Apr 16, 2024

mattsse Apr 15, 2024

AbnerZheng Apr 16, 2024

mattsse Apr 15, 2024

mattsse left a comment

feat: add rpc trait bindings for optimism specific endpoints #7621

feat: add rpc trait bindings for optimism specific endpoints #7621

Conversation

AbnerZheng commented Apr 13, 2024

mattsse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AbnerZheng commented Apr 15, 2024

mattsse commented Apr 15, 2024

AbnerZheng commented Apr 15, 2024

mattsse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattsse left a comment

Choose a reason for hiding this comment