Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: fixes behaviour of cursor delete_current on start item #7646

Merged
merged 3 commits into from Apr 17, 2024
Merged

storage: fixes behaviour of cursor delete_current on start item #7646

merged 3 commits into from Apr 17, 2024

Conversation

Ruteri
Copy link
Contributor

@Ruteri Ruteri commented Apr 15, 2024 •
edited

Note that the deleted item is what used to be returned by next and it, correctly, doesn't appear in the tx view.

@Ruteri Ruteri changed the title mdbx: adds a test showing inconsistent behaviour of dup cursor delete_current storage: fixes behaviour of cursor delete_current on start item Apr 16, 2024
@mattsse mattsse requested a review from rkrasiuk April 16, 2024 12:22
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-db Related to the database labels Apr 16, 2024
rkrasiuk
rkrasiuk reviewed Apr 17, 2024
View reviewed changes
crates/storage/db/src/abstraction/cursor.rs Outdated Show resolved Hide resolved
crates/storage/db/src/abstraction/cursor.rs Outdated Show resolved Hide resolved
crates/storage/db/src/abstraction/cursor.rs Outdated Show resolved Hide resolved
crates/storage/db/src/abstraction/cursor.rs Outdated Show resolved Hide resolved
crates/storage/db/src/implementation/mdbx/mod.rs Outdated Show resolved Hide resolved
crates/storage/db/src/implementation/mdbx/mod.rs Outdated Show resolved Hide resolved
@rkrasiuk rkrasiuk enabled auto-merge April 17, 2024 06:27
@rkrasiuk rkrasiuk added this pull request to the merge queue Apr 17, 2024
Merged via the queue into paradigmxyz:main with commit 70db3d8 Apr 17, 2024
27 checks passed
@Ruteri Ruteri deleted the delete-current-inconsistency branch April 17, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
A-db Related to the database C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruteri @rkrasiuk @mattsse