refactor: Drop reth_primitives::Log #7651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xqd
requested review from
rakita,
joshieDo,
shekhirin,
mattsse,
Rjected and
gakonst
as code owners
0xqd
force-pushed
the
refactor_drop_reth_primitives_log
branch
from
ad5bad5
to
e206cd8
Compare
onbjerg
changed the title
mattsse
requested changes
Apr 15, 2024
|
@mattsse I need help for the failed test at line 540 file proofs.rs. The input is identical, but the output seems to be difference cmpared to primitive::Log. |
mattsse
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
reth_primitives::Logsince we have implemented compact_codec for it instorage/codecscrate.Ref #7050
WIP