Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(discv5): fix panel filtered peers #7696

Merged
merged 1 commit into from Apr 17, 2024
Merged

fix(discv5): fix panel filtered peers #7696

merged 1 commit into from Apr 17, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Apr 17, 2024

Fixes calculation of peers which pass ENR filter, which before was showing peers that fail the filter.

@emhane emhane added A-observability Related to tracing, metrics, logs and other observability tools A-discv5 Related to discv5 discovery labels Apr 17, 2024
@emhane emhane requested a review from gakonst as a code owner April 17, 2024 10:58
onbjerg
onbjerg approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see, previously it was the amount of peers we filtered, not the amount that passed the filter

@emhane emhane added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit 69370e9 Apr 17, 2024
28 checks passed
@emhane emhane deleted the emhane/fix-panel-discv5 branch April 17, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@Rjected Rjected Awaiting requested review from Rjected

@mattsse mattsse Awaiting requested review from mattsse

@joshieDo joshieDo Awaiting requested review from joshieDo

@DaniPopes DaniPopes Awaiting requested review from DaniPopes

@shekhirin shekhirin Awaiting requested review from shekhirin

Assignees
No one assigned
Labels
A-discv5 Related to discv5 discovery A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emhane @onbjerg @rkrasiuk