Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grafana): adds missing panel for tx fetcher #7700

Merged
merged 3 commits into from Apr 18, 2024
Merged

fix(grafana): adds missing panel for tx fetcher #7700

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe63a7c
Add panel for monitoring duration of fetching pending hashes
emhane Apr 17, 2024
837ed72
Update panel description
emhane Apr 18, 2024
30e3af0
Fix lint
emhane Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/net/network/src/transactions/fetcher.rs
View file
Open in desktop
Expand Up @@ -717,7 +717,7 @@ impl TransactionFetcher {
/// The request hashes buffer is filled as if it's an eth68 request, i.e. smartly assemble
/// the request based on expected response size. For any hash missing size metadata, it is
/// guessed at [`AVERAGE_BYTE_SIZE_TX_ENCODED`].

///
/// Loops through hashes pending fetch and does:
///
/// 1. Check if a hash pending fetch is seen by peer.
Expand Down
186 changes: 153 additions & 33 deletions etc/grafana/dashboards/reth-mempool.json
View file
Open in desktop
Expand Up @@ -2324,7 +2324,7 @@
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
},
"description": "Frequency of transaction types seen in announcements",
"description": "Duration of one call to `TransactionFetcher::on_fetch_pending_hashes`.\n\nFind Peer - find an idle fallback peer for a hash pending fetch.\n\nFill Request - fill `GetPooledTransactions` request, for the found peer, with more hashes from cache of hashes pending fetch. ",
"fieldConfig": {
"defaults": {
"color": {
Expand Down Expand Up @@ -2376,7 +2376,7 @@
}
]
},
"unit": "cps",
"unit": "s",
"unitScale": true
},
"overrides": []
Expand All @@ -2387,7 +2387,7 @@
"x": 12,
"y": 53
},
"id": 214,
"id": 215,
"options": {
"legend": {
"calcs": [],
Expand All @@ -2408,14 +2408,14 @@
},
"disableTextWrap": false,
"editorMode": "builder",
"expr": "rate(reth_network_transaction_fetcher_legacy_sum{instance=\"$instance\"}[$__rate_interval])",
"expr": "reth_network_duration_find_idle_fallback_peer_for_any_pending_hash{instance=\"$instance\"}",
"fullMetaSearch": false,
"hide": false,
"includeNullMetadata": false,
"includeNullMetadata": true,
"instant": false,
"legendFormat": "Legacy",
"legendFormat": "Find Idle Peer",
"range": true,
"refId": "A",
"refId": "C",
"useBackend": false
},
{
Expand All @@ -2425,31 +2425,117 @@
},
"disableTextWrap": false,
"editorMode": "builder",
"expr": "rate(reth_network_transaction_fetcher_eip2930_sum{instance=\"$instance\"}[$__rate_interval])",
"expr": "reth_network_duration_fill_request_from_hashes_pending_fetch{instance=\"$instance\"}",
"fullMetaSearch": false,
"hide": false,
"includeNullMetadata": false,
"includeNullMetadata": true,
"instant": false,
"legendFormat": "Eip2930",
"legendFormat": "Fill Request",
"range": true,
"refId": "B",
"useBackend": false
}
],
"title": "Fetch Hashes Pending Fetch Duration",
"type": "timeseries"
},
{
"datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
},
"description": "Durations of one call to poll `NetworkManager` future, and its nested function calls.\n\nNetwork Handle Message - stream network handle messages from `TransactionsManager`;\nSwarm Events - stream transaction gossip from `Swarm`",
emhane marked this conversation as resolved.
Show resolved Hide resolved
"fieldConfig": {
"defaults": {
"color": {
"mode": "palette-classic"
},
"custom": {
"axisBorderShow": false,
"axisCenteredZero": false,
"axisColorMode": "text",
"axisLabel": "",
"axisPlacement": "auto",
"barAlignment": 0,
"drawStyle": "line",
"fillOpacity": 0,
"gradientMode": "none",
"hideFrom": {
"legend": false,
"tooltip": false,
"viz": false
},
"insertNulls": false,
"lineInterpolation": "linear",
"lineWidth": 1,
"pointSize": 5,
"scaleDistribution": {
"type": "linear"
},
"showPoints": "auto",
"spanNulls": false,
"stacking": {
"group": "A",
"mode": "none"
},
"thresholdsStyle": {
"mode": "off"
}
},
"mappings": [],
"thresholds": {
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
},
{
"color": "red",
"value": 80
}
]
},
"unit": "s",
"unitScale": true
},
"overrides": []
},
"gridPos": {
"h": 8,
"w": 12,
"x": 0,
"y": 61
},
"id": 209,
"options": {
"legend": {
"calcs": [],
"displayMode": "list",
"placement": "bottom",
"showLegend": true
},
"tooltip": {
"mode": "single",
"sort": "none"
}
},
"targets": [
{
"datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
},
"disableTextWrap": false,
"editorMode": "builder",
"expr": "rate(reth_network_transaction_fetcher_eip1559_sum{instance=\"$instance\"}[$__rate_interval])",
"expr": "reth_network_duration_poll_network_handle{instance=\"$instance\"}",
"fullMetaSearch": false,
"hide": false,
"includeNullMetadata": false,
"includeNullMetadata": true,
"instant": false,
"legendFormat": "Eip1559",
"legendFormat": "Network Handle Messages",
"range": true,
"refId": "C",
"refId": "A",
"useBackend": false
},
{
Expand All @@ -2459,26 +2545,43 @@
},
"disableTextWrap": false,
"editorMode": "builder",
"expr": "rate(reth_network_transaction_fetcher_eip4844_sum{instance=\"$instance\"}[$__rate_interval])",
"expr": "reth_network_duration_poll_swarm{instance=\"$instance\"}",
"fullMetaSearch": false,
"hide": false,
"includeNullMetadata": false,
"includeNullMetadata": true,
"instant": false,
"legendFormat": "Eip4844",
"legendFormat": "Swarm Events",
"range": true,
"refId": "D",
"refId": "B",
"useBackend": false
},
{
"datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
},
"disableTextWrap": false,
"editorMode": "builder",
"expr": "reth_network_duration_poll_network_manager{instance=\"$instance\"}",
"fullMetaSearch": false,
"hide": false,
"includeNullMetadata": true,
"instant": false,
"legendFormat": "Total Network Manager Future",
emhane marked this conversation as resolved.
Show resolved Hide resolved
"range": true,
"refId": "C",
"useBackend": false
}
],
"title": "Announced Transactions by Type",
"title": "Network Manager Poll Duration",
"type": "timeseries"
},
{
"datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
},
"description": "Durations of one call to poll `NetworkManager` future, and its nested function calls.\n\nNetwork Handle Message - stream network handle messages from `TransactionsManager`;\nSwarm Events - stream transaction gossip from `Swarm`",
"description": "Frequency of transaction types seen in announcements",
"fieldConfig": {
"defaults": {
"color": {
Expand Down Expand Up @@ -2530,18 +2633,18 @@
}
]
},
"unit": "s",
"unit": "cps",
"unitScale": true
},
"overrides": []
},
"gridPos": {
"h": 8,
"w": 12,
"x": 0,
"x": 12,
"y": 61
},
"id": 209,
"id": 214,
"options": {
"legend": {
"calcs": [],
Expand All @@ -2562,12 +2665,12 @@
},
"disableTextWrap": false,
"editorMode": "builder",
"expr": "reth_network_duration_poll_network_handle{instance=\"$instance\"}",
"expr": "rate(reth_network_transaction_fetcher_legacy_sum{instance=\"$instance\"}[$__rate_interval])",
"fullMetaSearch": false,
"hide": false,
"includeNullMetadata": true,
"includeNullMetadata": false,
"instant": false,
"legendFormat": "Network Handle Messages",
"legendFormat": "Legacy",
"range": true,
"refId": "A",
"useBackend": false
Expand All @@ -2579,12 +2682,12 @@
},
"disableTextWrap": false,
"editorMode": "builder",
"expr": "reth_network_duration_poll_swarm{instance=\"$instance\"}",
"expr": "rate(reth_network_transaction_fetcher_eip2930_sum{instance=\"$instance\"}[$__rate_interval])",
"fullMetaSearch": false,
"hide": false,
"includeNullMetadata": true,
"includeNullMetadata": false,
"instant": false,
"legendFormat": "Swarm Events",
"legendFormat": "Eip2930",
"range": true,
"refId": "B",
"useBackend": false
Expand All @@ -2596,18 +2699,35 @@
},
"disableTextWrap": false,
"editorMode": "builder",
"expr": "reth_network_duration_poll_network_manager{instance=\"$instance\"}",
"expr": "rate(reth_network_transaction_fetcher_eip1559_sum{instance=\"$instance\"}[$__rate_interval])",
"fullMetaSearch": false,
"hide": false,
"includeNullMetadata": true,
"includeNullMetadata": false,
"instant": false,
"legendFormat": "Total Network Manager Future",
"legendFormat": "Eip1559",
"range": true,
"refId": "C",
"useBackend": false
},
{
"datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
},
"disableTextWrap": false,
"editorMode": "builder",
"expr": "rate(reth_network_transaction_fetcher_eip4844_sum{instance=\"$instance\"}[$__rate_interval])",
"fullMetaSearch": false,
"hide": false,
"includeNullMetadata": false,
"instant": false,
"legendFormat": "Eip4844",
"range": true,
"refId": "D",
"useBackend": false
}
],
"title": "Network Manager Poll Duration",
"title": "Announced Transactions by Type",
"type": "timeseries"
},
{
Expand Down