Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(discv5): fix bug flip byte lookup tgt #7764

Merged
merged 10 commits into from Apr 20, 2024
Merged

fix(discv5): fix bug flip byte lookup tgt #7764

merged 10 commits into from Apr 20, 2024
+29 −44

Conversation

emhane
Copy link
Member

@emhane emhane commented Apr 19, 2024 •
edited

  • Flips index 0 (log2distance 1) in lookup target selection. Previously the code was taking log2distance as param, now it takes kbucket index as param to be easier to follow along.
  • Fixes flaky test at boundary where log2distance is a multiple of 8

leaving bit flipping up to closes #7763

@emhane emhane changed the title fix(discv5): fix bug flip bit lookup tgt fix(discv5): fix bug flip byte lookup tgt Apr 19, 2024
@mattsse mattsse added the A-networking Related to networking in general label Apr 20, 2024
DaniPopes
DaniPopes reviewed Apr 20, 2024
View reviewed changes
crates/net/discv5/src/lib.rs Outdated Show resolved Hide resolved
crates/net/discv5/src/lib.rs Outdated Show resolved Hide resolved
emhane and others added 3 commits April 20, 2024 18:49
@emhane @DaniPopes
Flip exact byte
2ef9ab2 
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
@emhane @DaniPopes
Fix syntax
9fa3c21 
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
@emhane
Adjust test to check eaxct bit flipped
cb7f35e
@emhane emhane requested a review from DaniPopes April 20, 2024 17:35
@emhane emhane added this pull request to the merge queue Apr 20, 2024
Merged via the queue into main with commit d81cf8a Apr 20, 2024
27 checks passed
@emhane emhane deleted the emhane/fix-lookup-tgt branch April 20, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@shekhirin shekhirin Awaiting requested review from shekhirin

@onbjerg onbjerg Awaiting requested review from onbjerg

@joshieDo joshieDo Awaiting requested review from joshieDo

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees

@Rjected Rjected

Labels
A-networking Related to networking in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(discv5): flip exact bit in node id
4 participants
@emhane @DaniPopes @Rjected @mattsse