Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Eip 6110 #8204

Merged
merged 7 commits into from
May 13, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions crates/ethereum/evm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ revm-precompile = { version = "7.0.0", features = ["std"], default-features = fa

# Alloy
alloy-consensus.workspace = true
alloy-eips.workspace = true
alloy-rlp.workspace = true
alloy-sol-types.workspace = true

# misc
tracing.workspace = true
Expand Down
75 changes: 75 additions & 0 deletions crates/ethereum/evm/src/eip6110.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
//! EIP-6110 deposit requests parsing
use alloy_consensus::Request;
use alloy_eips::eip6110::{DepositRequest, MAINNET_DEPOSIT_CONTRACT_ADDRESS};
use alloy_sol_types::{sol, SolEvent};
use reth_interfaces::executor::BlockValidationError;
use reth_primitives::Receipt;
use revm_primitives::Log;

pub(crate) fn parse_deposits_from_receipts(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it pub

receipts: &[Receipt],
) -> Result<Vec<Request>, BlockValidationError> {
let res = receipts
.iter()
.flat_map(|receipt| receipt.logs.iter())
// No need to filter for topic because there's only one event and that's the Deposit event
// in the deposit contract.
.filter(|log| log.address == MAINNET_DEPOSIT_CONTRACT_ADDRESS)
.map(|log| DepositEvent::decode_log(log, false))
.map(|res| {
let deposit = parse_deposit_from_log(&res?);
Ok(Request::DepositRequest(deposit))
})
.collect::<Result<Vec<_>, _>>()
// todo: this is ugly, we should clean it up
.map_err(|err: alloy_sol_types::Error| {
BlockValidationError::DepositRequestDecode(err.to_string())
})?;
Ok(res)
}

sol! {
#[allow(missing_docs)]
event DepositEvent(
bytes pubkey,
bytes withdrawal_credentials,
bytes amount,
bytes signature,
bytes index
);
}

fn parse_deposit_from_log(log: &Log<DepositEvent>) -> DepositRequest {
Comment on lines +33 to +44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should put the DepositEvent in alloy-eips for the relevant eip, and have a conversion from DepositEvent → DepositRequest in alloy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, let's do it after

// SAFETY: These `expect` https://github.com/ethereum/consensus-specs/blob/5f48840f4d768bf0e0a8156a3ed06ec333589007/solidity_deposit_contract/deposit_contract.sol#L107-L110
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be NOTE or something else, SAFETY should be reserved for unsafe {}

Copy link
Member Author

@gakonst gakonst May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Panics in the doc of the function actually

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// are safe because the `DepositEvent` is the only event in the deposit contract and the length
// checks are done there.
DepositRequest {
pubkey: log
.pubkey
.as_ref()
.try_into()
.expect("pubkey length should be enforced in deposit contract"),
withdrawal_credentials: log
.withdrawal_credentials
.as_ref()
.try_into()
.expect("pubkey length should be enforced in deposit contract"),
amount: u64::from_le_bytes(
log.amount
.as_ref()
.try_into()
.expect("pubkey length should be enforced in deposit contract"),
),
signature: log
.signature
.as_ref()
.try_into()
.expect("pubkey length should be enforced in deposit contract"),
index: u64::from_le_bytes(
log.index
.as_ref()
.try_into()
.expect("pubkey length should be enforced in deposit contract"),
),
}
}
12 changes: 8 additions & 4 deletions crates/ethereum/evm/src/execute.rs
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ where
transaction_gas_limit: transaction.gas_limit(),
block_available_gas,
}
.into())
.into());
}

EvmConfig::fill_tx_env(evm.tx_mut(), transaction, *sender);
Expand Down Expand Up @@ -209,13 +209,17 @@ where
gas: GotExpected { got: cumulative_gas_used, expected: block.gas_used },
gas_spent_by_tx: receipts.gas_spent_by_tx()?,
}
.into())
.into());
}

// Collect all EIP-6110 deposits
let deposits = crate::eip6110::parse_deposits_from_receipts(&receipts)?;
gakonst marked this conversation as resolved.
Show resolved Hide resolved

// Collect all EIP-7685 requests
let withdrawal_requests =
post_block_withdrawal_requests(&self.chain_spec, block.timestamp, &mut evm)?;
Copy link
Member

@DaniPopes DaniPopes May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should accumulate, extending a vector, rather than two vecs and concatenating after. Can be done with &mut Vec as argument and transforming the iterator into a for loop

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The withdrawal function returns a Vec<Request> via Vec<Request>::decode and I cannot break out of the iterator without collecting so not sure how to do that here, also prob not big perf given smol list

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see, what about moving the parse_deposits to after post_block and extending that list?

let requests = withdrawal_requests;
// TODO: Does order matter?
let requests = [deposits, withdrawal_requests].concat();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes and this is the correct order

gakonst marked this conversation as resolved.
Show resolved Hide resolved

Ok(EthExecuteOutput { receipts, requests, gas_used: cumulative_gas_used })
}
Expand Down Expand Up @@ -311,7 +315,7 @@ where
receipts.iter(),
) {
debug!(target: "evm", %error, ?receipts, "receipts verification failed");
return Err(error)
return Err(error);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe

Suggested change
return Err(error);
return Err(error)

};
}

Expand Down
3 changes: 3 additions & 0 deletions crates/ethereum/evm/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ pub mod verify;
/// Ethereum DAO hardfork state change data.
pub mod dao_fork;

/// [EIP-6110](https://eips.ethereum.org/EIPS/eip-6110) handling.
pub mod eip6110;

mod instructions;

/// Ethereum-related EVM configuration.
Expand Down
11 changes: 10 additions & 1 deletion crates/interfaces/src/executor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,21 @@ pub enum BlockValidationError {
/// The error message.
message: String,
},
/// EVM error during withdrawal requests contract call
/// EVM error during withdrawal requests contract call [EIP-7002]
///
/// [EIP-7002]: https://eips.ethereum.org/EIPS/eip-7002
#[error("failed to apply withdrawal requests contract call: {message}")]
WithdrawalRequestsContractCall {
/// The error message.
message: String,
},
/// Error when decoding deposit requests from receipts [EIP-6110]
///
/// [EIP-6110]: https://eips.ethereum.org/EIPS/eip-6110
// TODO(gakonst): This is an RLP decoding error but we don't import alloy_rlp here,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not? It should be in reth_primitives already

// do we want to?
#[error("could not decode deposit request: {0}")]
DepositRequestDecode(String),
}

/// BlockExecutor Errors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,11 @@ impl BundleStateWithReceipts {
/// Transform block number to the index of block.
fn block_number_to_index(&self, block_number: BlockNumber) -> Option<usize> {
if self.first_block > block_number {
return None
return None;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grrrr

}
let index = block_number - self.first_block;
if index >= self.receipts.len() as u64 {
return None
return None;
}
Some(index as usize)
}
Expand Down Expand Up @@ -269,7 +269,7 @@ impl BundleStateWithReceipts {
/// If the target block number is not included in the state block range.
pub fn split_at(self, at: BlockNumber) -> (Option<Self>, Self) {
if at == self.first_block {
return (None, self)
return (None, self);
}

let (mut lower_state, mut higher_state) = (self.clone(), self);
Expand Down