Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change build_empty_payload to require &self #8646

Merged
merged 1 commit into from
Jun 6, 2024
Merged

chore: change build_empty_payload to require &self #8646

merged 1 commit into from
Jun 6, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 6, 2024

implementers might want to have access to settings and dynamic control over this setting

@mattsse mattsse added the A-block-building Related to block building label Jun 6, 2024
Rjected
Rjected approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep this makes sense

@mattsse mattsse enabled auto-merge June 6, 2024 15:58
@mattsse mattsse added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 49c8c96 Jun 6, 2024
30 checks passed
@mattsse mattsse deleted the matt/change-build-empty-to branch June 6, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-block-building Related to block building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattsse @Rjected