Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing payload behaviour #8649

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 6, 2024

Closes #8647

this change only affects OP
previously we were rebuilding the block in place if the CL requests the payload before the initial task finished. we don't gain anything here because we need to execute the block as is anyway.

now this simply awaits until the job in progress finishes

@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-op-reth Related to Optimism and op-reth labels Jun 6, 2024
@github-actions github-actions bot added A-block-building Related to block building C-enhancement New feature or request labels Jun 6, 2024
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, smol nit

crates/payload/basic/src/lib.rs Outdated Show resolved Hide resolved
crates/payload/basic/src/lib.rs Outdated Show resolved Hide resolved
mattsse and others added 2 commits June 6, 2024 19:55
Co-authored-by: Federico Gimenez <fgimenez@users.noreply.github.com>
@mattsse mattsse enabled auto-merge June 6, 2024 17:57
@mattsse mattsse added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit e2cba9f Jun 6, 2024
29 checks passed
@mattsse mattsse deleted the matt/add-missing-payload-behaviour branch June 6, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building A-op-reth Related to Optimism and op-reth C-enhancement New feature or request C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace Payloadloadbuilder::on_missing_payload with a type that tells the service how to behave
3 participants