Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move discv5 logic for op to reth-node-optimism #8690

Merged
merged 3 commits into from
Jun 11, 2024
Merged

refactor: move discv5 logic for op to reth-node-optimism #8690

merged 3 commits into from
Jun 11, 2024

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Jun 8, 2024

fix #8499

mattsse
mattsse approved these changes Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pending @emhane

crates/optimism/node/src/node.rs Show resolved Hide resolved
@mattsse mattsse added the A-op-reth Related to Optimism and op-reth label Jun 8, 2024
@qiweiii qiweiii marked this pull request as ready for review June 8, 2024 11:22
emhane
emhane approved these changes Jun 8, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/node-core/src/args/network.rs Show resolved Hide resolved
@mattsse mattsse added this pull request to the merge queue Jun 11, 2024
Merged via the queue into paradigmxyz:main with commit 3202c90 Jun 11, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane emhane approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable discv5 for op in reth-node-optimism crate
3 participants
@qiweiii @mattsse @emhane