feat: add append_receipts function #8718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamuik16
requested review from
rakita,
joshieDo,
shekhirin,
onbjerg and
rkrasiuk
as code owners
mattsse
requested changes
Jun 10, 2024
mattsse
added
C-perf
shekhirin
reviewed
Jun 10, 2024
crates/storage/provider/src/bundle_state/bundle_state_with_receipts.rs
Outdated
Show resolved
Hide resolved
|
@mattsse @shekhirin ready for your feedback. tracked ci failure and issue seems to be related to #8166. |
shekhirin
reviewed
Jun 10, 2024
shekhirin
added
A-static-files
if we return an Option, we'll have to do the error handling, so I have i have suggestion, if the receipts are empty, we can simply return the last |
shekhirin
requested changes
Jun 11, 2024
crates/storage/provider/src/bundle_state/bundle_state_with_receipts.rs
Outdated
Show resolved
Hide resolved
Rjected
reviewed
Jun 11, 2024
shekhirin
approved these changes
Jun 11, 2024
shekhirin
requested changes
Jun 11, 2024
| // If receipts are empty, we can simply return the current TxNumber as seen in the static | ||
| // file. | ||
| if receipts_iter.peek().is_none() { | ||
| return Ok(self.writer.user_header().tx_end().expect("qed")); |
There was a problem hiding this comment.
the CI is failing because it's not guaranteed to have at least one receipt in static files. Let's make this method return Option<TxNumber>.
shekhirin
approved these changes
Jun 11, 2024
|
@mattsse PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8466