Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip failed new payload submission #9003

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: skip failed new payload submission #9003

merged 1 commit into from
Jun 20, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 20, 2024

closes #9000

this simply ignores the error and continues with the fcu, the node can handle missed payloads by downloading them from p2p

@mattsse mattsse added the C-bug An unexpected or incorrect behavior label Jun 20, 2024
@mattsse mattsse requested a review from shekhirin June 20, 2024 20:59
@mattsse mattsse enabled auto-merge June 20, 2024 21:00
@mattsse mattsse added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 135e11b Jun 20, 2024
31 checks passed
@mattsse mattsse deleted the matt/ignore-failed-new-payload-request branch June 20, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--debug.etherscan should not crash the node
2 participants
@mattsse @shekhirin