Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream trace pretty-printer from Foundry #14

Open
DaniPopes opened this issue Jan 28, 2024 · 2 comments
Open

Upstream trace pretty-printer from Foundry #14

DaniPopes opened this issue Jan 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Jan 28, 2024

The main code lives here: https://github.com/foundry-rs/foundry/blob/4c73702d605287c39cb73a6d9a6879c5c3ead0dc/crates/evm/traces/src/lib.rs#L70

This should be refactored into a pretty-printer struct generic over a Write writer and an optional TraceDecoder trait used to decode the traces before printing them.

Trace decoding should be kept outside of this crate by adding optional "decoded" fields for call data and return data.

@DaniPopes DaniPopes added the enhancement New feature or request label Jan 28, 2024
DaniPopes added a commit that referenced this issue Feb 15, 2024
Will need a follow-up to add the "decoded" fields.

Ref #14
@klkvr
Copy link
Contributor

klkvr commented Mar 18, 2024

@DaniPopes why it was chosen to keep decoding logic in foundry?

the idea is to add additional decoded_call, decoded_return, etc to CallTrace right?

@DaniPopes
Copy link
Member Author

It's not strictly necessary to be upstreamed and the current implementation is very foundry specific

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants