Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransactionDetails screen #21

Merged

Conversation

therealharpaljadeja
Copy link
Contributor

@therealharpaljadeja therealharpaljadeja commented Aug 29, 2023

  • useTransaction hook
  • useTransactionReceipt hook
  • useTransactionConfirmations hook
  • Add TransactionDetails Link to block-details screen
  • Add TransactionDetails Link to transactions tab
  • input data wrapping
  • Link from transactions to blocks (problem hash router)
  • Transaction logs (I propose tabs in the transaction view)

You can see in the below screenshot that I am trying to go from transaction to a block (check url at bottom left corner), but to achieve this I will have to nest in the routes (is that the right way?)

image image

@jxom
Copy link
Member

jxom commented Aug 30, 2023

Acknowledged! Will review shortly.

@jxom
Copy link
Member

jxom commented Aug 30, 2023

Can you rebase main back into here? Modified some things on Text so it can wrap long text like data better.

As for the routes, might be better to flatten them (so it's just /transaction/:transactionHash) as we can retrieve transactions with just a hash (don't need block number).

@therealharpaljadeja
Copy link
Contributor Author

therealharpaljadeja commented Aug 30, 2023

If routes are flattened, how do I go from block screen to transaction screen...

I think I did something wrong with the rebase, I don't use it (and I don't know how to) 😓 but let me know...

@ditto-eth ditto-eth mentioned this pull request Aug 30, 2023
@jxom
Copy link
Member

jxom commented Aug 30, 2023

You can just push the route to /transaction/0xdeadbeef or something.

Can fix up the rebase for you shortly.

@jxom jxom force-pushed the issue-10-transaction-details branch from d017238 to b53744b Compare August 31, 2023 01:22
@jxom jxom force-pushed the issue-10-transaction-details branch from b53744b to 4e4782c Compare August 31, 2023 03:04
@jxom jxom merged commit 2ae6721 into paradigmxyz:main Aug 31, 2023
3 checks passed
@therealharpaljadeja therealharpaljadeja deleted the issue-10-transaction-details branch January 5, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants