Reflect not active rpc #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxom
reviewed
Sep 2, 2023
src/components/RpcDownMessage.tsx
Outdated
There was a problem hiding this comment.
Good start! Might be nice if we could use Radix Dialog so we can get all the accessibility features out of the box here!
There was a problem hiding this comment.
Thanks ! Sure, let me know if what i've done works for you now.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a message that appears when the rpc goes down (created a new RpcDownMessage component using existing styles), preventing the user from displaying data/doing actions that require rpc to be up. The message disappears as soon as the rpc is up.
Followed indications of the related issue (see below) to have an experience akin to Browser DevTools.
Related issue
#9
How Has This Been Tested?
On dev environment, produced expected behaviour by shutting down rpc, then turning it up again. Everything works as expected (see screens below).
Screenshots