Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GNOME Shell 3.32.0 #511

Closed
srinskit opened this issue Mar 17, 2019 · 19 comments
Closed

Support for GNOME Shell 3.32.0 #511

srinskit opened this issue Mar 17, 2019 · 19 comments

Comments

@srinskit
Copy link

Extension doesn't work with GNOME Shell 3.32.0.

System details:

$ gnome-shell --version
GNOME Shell 3.32.0
$ uname -r
5.0.2-arch1-1-ARCH

@Hentioe
Copy link

Hentioe commented Mar 17, 2019

Sorry, I made a bad beginning. So everyone should not reply to +1 again. 👍 is enough.

@MasinAD
Copy link

MasinAD commented Mar 17, 2019

+1
According to lg:

TypeError: this._construct is undefined

@allexlima
Copy link

+1

@alephnull
Copy link

See #508

@BloodyIron
Copy link

Once this is addressed can we get a new release with notes please? Haven't had one on github since Aug 2018...

worldofpeace added a commit to NixOS/nixpkgs that referenced this issue Apr 2, 2019
hedning pushed a commit to hedning/nixpkgs that referenced this issue Apr 4, 2019
jtojnar pushed a commit to NixOS/nixpkgs that referenced this issue Apr 5, 2019
@soaringowl2145
Copy link

When this does get fixed will the version in the Ubuntu 19.04 repository be updated with the fix?

@chrisspen
Copy link
Collaborator

I've merged #510 so master should now support Gnome 3.32. I'm going to poll some other PR authors to update conflicts and try to get their fixes in before I push another release. In the meantime, please test master and confirm this resolves issues on Ubuntu 19.

@soaringowl2145
Copy link

I've merged #510 so master should now support Gnome 3.32. I'm going to poll some other PR authors to update conflicts and try to get their fixes in before I push another release. In the meantime, please test master and confirm this resolves issues on Ubuntu 19.

What is a PR author?

@chrisspen
Copy link
Collaborator

@soaringowl2145 The author of a pull request :)

@zeppe
Copy link

zeppe commented Apr 22, 2019

In the meantime, please test master and confirm this resolves issues on Ubuntu 19.

It works on Ubuntu 19.02.

@BloodyIron
Copy link

@zeppe do you mean Ubuntu 19.04?

@dr-br
Copy link

dr-br commented Apr 23, 2019

Does work on Ubuntu 19.04 with Wayland. X11 suffers from "LOOOOOOONNNNG login times with system-monitor enabled" as described in #515 (login not possible at all)

@zeppe
Copy link

zeppe commented Apr 23, 2019

@zeppe do you mean Ubuntu 19.04?

:) yes of course, sorry.

@jendakol
Copy link

jendakol commented Apr 26, 2019

FYI master works for me on Ubuntu 19.04:

GNOME Shell 3.32.0
5.0.0-13-generic

Didn't observe any slowdown on Xorg.

@BloodyIron
Copy link

Still only see 3.30 support on : https://extensions.gnome.org/extension/120/system-monitor/

Also, releases section of this github project shows no releases since Aug 2018... CMON GUYS.

@skyghis
Copy link

skyghis commented Apr 27, 2019

@chrisspen master works on my Ubuntu 19.04 without any issue.

  • No long login issue
  • Preference dialog display fine
  • Popup windows show up to date information and refresh in real time.

Thanks @shemgp for the good work 👍

Should probably bake release.

@chrisspen
Copy link
Collaborator

I've published a new release, and have uploaded it to EGO for review.

@chrisspen
Copy link
Collaborator

The release has been approved and is now public on the extensions site.

@ryneches
Copy link

ryneches commented May 8, 2019

When I re-enabled it on Ubuntu 19.04 with Wayland, I ran into a weird case where it kept loading new instances of system-monitor until it filled the entire menubar. Restarting the desktop environment cleared the problem, and now it's running fine.

I've run into weird behavior before when loading a Gnome applet for the first time, so I'm not sure if this is a bug in system-monitor. Some initialization code to make sure the applet isn't already running might help avoid edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests