Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erronous configuration errors when no pyproject.toml file is found #21

Closed
parafoxia opened this issue Feb 6, 2022 · 1 comment
Closed

Erronous configuration errors when no pyproject.toml file is found #21

parafoxia opened this issue Feb 6, 2022 · 1 comment
Assignees
@parafoxia @Jonxslays
Labels
pending investigation Still needs looking into

Comments

@parafoxia
Copy link
Owner

Describe the bug
len8 states that "'pyproject.toml' is not a valid configuration file" when the file does not exist. For those with projects that purposefully do not contain this file, this a confusing an annoying error.

To Reproduce
Run len8 on a project with no pyproject.toml file.

Expected behavior
len8 does not complain.

System Information:

  • OS: Debian 11 via WSL (Windows 11)
  • Python Version: 3.10.2
  • len8 Version: 0.7.0
@parafoxia parafoxia added the pending investigation Still needs looking into label Feb 6, 2022
@parafoxia parafoxia changed the title Bug Report Erronous configuration errors when no pyproject.toml file is found Feb 6, 2022
@parafoxia
Copy link
Owner Author

Some fixes for this would be:

  • Change the error to a warning, saying "No configuration file found" or something akin
  • Remove the error entirely, or set a different default

parafoxia added a commit that referenced this issue Feb 6, 2022
@parafoxia
Remove erronous print statement (#21)
b505aea 
Closes #21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parafoxia parafoxia

@Jonxslays Jonxslays

Labels
pending investigation Still needs looking into
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parafoxia @Jonxslays